Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply correct normalize absmax calculation to drawBars() #916

Merged
merged 1 commit into from
Jan 11, 2017
Merged

Apply correct normalize absmax calculation to drawBars() #916

merged 1 commit into from
Jan 11, 2017

Conversation

chrisparton1991
Copy link
Contributor

Fixed #907

@chrisparton1991 chrisparton1991 mentioned this pull request Jan 10, 2017
Closed
@chrisparton1991
Copy link
Contributor Author

If and when this change gets applied to the next branch, I think we should move the absmax code out into a utility method, as the same code is now used in 4 places.

@katspaugh katspaugh merged commit b0c0a8b into katspaugh:master Jan 11, 2017
@katspaugh
Copy link
Owner

Thanks! 👍

mspae pushed a commit to mspae/wavesurfer.js that referenced this pull request Feb 5, 2017
@chrisparton1991 @mspae
Apply correct normalize absmax calculation to drawBars() (katspaugh#916)
3b9249a
thijstriemstra pushed a commit that referenced this pull request Feb 6, 2017
@mspae @thijstriemstra
Next: Minor bugfixes and ports of changes from master (#966)
bb04a60 
* fixed wrong var reference causing the bottom half of the waves to not draw

* replaced loops of this.canvases with correct for loop or forEach where possible

* turned unnecessary let into const in multicanvas

* Only call media.load() if it exists (#875)

* When running code that uses Wavesurfer under PhantomJS (even if not explicitly testing the Wavesurfer code), the JS interpreter crashes because PhantomJS DOM `<audio>` elements don't have a `load()` method. This change skips that one line if the method doesn't exist.

* Apply correct normalize absmax calculation to drawBars() (#916)

* fix draw wrong position while playing backward seeking (#918)

* fix draw wrong position while playing backward seeking

* fix spelling mistake

* add getPlaybackRate (#936)

* added es6 method short notation for #f185d97c825a92bfb69be80091587a9a19f66594

* Updated render function for drawPeaks/getPeaks (#959)

* Updated the render function to call the new version of the getPeaks and drawPeaks calls which now require start and end parameters.  Fixes flat waveform drawing in minimap plugin.

* changed vars to const where possible in ported bugfix commits from master branch

* fixed split channel call to drawWave and drawPeaks
JulienFontaine pushed a commit to JulienFontaine/wavesurfer.js that referenced this pull request Feb 28, 2017
BUGFIX: applied katspaugh#916 on top of v1.2.8
362e49a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrisparton1991 @katspaugh