Radio links #50
Merged
Radio links #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katur
reviewed
Mar 25, 2023
Comment on lines
186
to
188
| .external-links | ||
| display: flex | ||
| align-items: center |
There was a problem hiding this comment.
Nit: I don't love that this is repeated, but don't mind waiting to fix. Or, we could move it to top-level (qualified as podcast-external-links), a la .audio-with-download
There was a problem hiding this comment.
I addressed this by extracting styles for that component to their own sheet. Good idea!
katur
reviewed
Mar 25, 2023
| @@ -191,6 +213,13 @@ $mobile-breakpoint: 500px | |||
| @include markdown-image-wrapper(500px) | |||
|
|
|||
|
|
|||
| .audio-with-download | |||
There was a problem hiding this comment.
This might affect "Sound Recordings" as well. If so, maybe it shouldn't live in the radio.sass (since it is included elsewhere)
There was a problem hiding this comment.
I checked and this fix applied to that page as well 🤙
There was a problem hiding this comment.
We moved these styles to the elements sheet, which handles more globally-applicable element styles.
… detail page to bottom
… styles to its own sheet
Thank you!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some style tweaks in the radio section, including adding external links to the radio program permalink page.
List page
audioelement and download iconDetail page
audioelement and download iconOther fixes