Search action using method argument #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genya0407
commented
Jan 2, 2022
mrblib/shelf/dispatcher.rb
Outdated
| @@ -43,8 +43,9 @@ def initialize(map = {}) | |||
| def call(env) | |||
| path = env[PATH_INFO] | |||
| method = R3.method_code(env[REQUEST_METHOD]) | |||
| raise ArgumentError, "Invalid HTTP method: #{env[REQUEST_METHOD].inspect}." unless method | |||
There was a problem hiding this comment.
Without this, if we get an invalid HTTP request method, Shelf raises confusing an error like TypeError: can't convert nil to Integer.
There was a problem hiding this comment.
that should also result in an HTTP 405 response instead of an server exception
katzer
reviewed
Apr 11, 2022
test/builder.rb
Outdated
| @@ -139,7 +139,17 @@ def self.env_for(uri = '', opts = {}) | |||
| assert_equal 200, app.call(env_for('/any', method: 'PUT'))[0] | |||
| assert_equal 200, app.call(env_for('/any', method: 'GET'))[0] | |||
| assert_equal 200, app.call(env_for('/put', method: 'PUT'))[0] | |||
| assert_equal 405, app.call(env_for('/put', method: 'GET'))[0] | |||
| assert_equal 404, app.call(env_for('/put', method: 'GET'))[0] | |||
There was a problem hiding this comment.
I think HTTP 405 method not allowed should be returned in that case
|
@katzer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we define two actions with the same path but a different method, requests pointing to the path result in unintuitive behavior:
This is because, in dispatching requests, Shelf's current implementation does not pass
methodtoR3::Tree#match.In order to fix this issue, I modified Dispatcher to use
methodin addition topathto match@tree.