Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled all php://xxxxxx targets #66

Merged
merged 1 commit into from
Sep 15, 2015
Merged

Enabled all php://xxxxxx targets #66

merged 1 commit into from
Sep 15, 2015

Conversation

TeslaDethray
Copy link
Contributor

This tweak allows users to make use of php://stderr and other such destinations. Without, trying to target STDERR will err when attempting to create the handle.

@onno-vos-dev
Copy link
Contributor

@tesla: I'm the one who originally implemented the log to php targets and I vaguely remember I had a reason for these targeting only these specific outputs.

Are we sure it works for all php targets? I can't remember why I chose for this implementation but something in my mind tells me I tried your implementation and ran into some troubles. Maybe I'm mistaken though....?

@TeslaDethray
Copy link
Contributor Author

@onno-vos-dev: Well, it doesn't actually work for php://filter, php://input, or php://stdin, but those aren't valid targets anyway. (It doesn't cause any problems, though. If someone has some clever way to use those as targets, then it would probably work.) It does work for php://memory, php://temp, and php://stderr.

I've been curious - why wasn't the logger set up to go to STDERR, but to STDOUT?

@onno-vos-dev
Copy link
Contributor

Honestly I don't know why we excluded stderr... I don't think we really had a valid reason for it.

All I know is I was working from:
#34

And no stderr was mentioned there so I'm guessing I just left it at that.

I just tried out your branch and all is good so I say: Ship it!

(On my phone so sorry for not putting nice links and @ tags)

katzgrau added a commit that referenced this pull request Sep 15, 2015
Enabled all php://xxxxxx targets
@katzgrau katzgrau merged commit 26f3646 into katzgrau:master Sep 15, 2015
@katzgrau
Copy link
Owner

Shipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants