Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for https://tools.ietf.org/html/rfc4180#page-3 paragraph 7 #31

Merged
merged 2 commits into from
Jun 27, 2017
Merged

fix for https://tools.ietf.org/html/rfc4180#page-3 paragraph 7 #31

merged 2 commits into from
Jun 27, 2017

Conversation

dozen1488
Copy link

@kauegimenes According to
https://tools.ietf.org/html/rfc4180#page-3
i propose to enclose strings, containing quotes, with more quotes.
Please, read https://tools.ietf.org/html/rfc4180#page-3 before approving or declining this commit.
In case of approving, please, rewrite tests.

@kaue
Copy link
Owner

kaue commented Jun 26, 2017

@dozen1488 Thanks for the PR!

@papswell What you think about this?

@papswell
Copy link
Collaborator

Sure, we should merge this, it makes the output more consistent, plus it fits the specs :)

@dozen1488 can you give me access to your repo so that i can push the updated tests ?
Thanks

@dozen1488
Copy link
Author

@papswell i guess i'v sent the invite. You have a push access now.

@dozen1488
Copy link
Author

@kauegimenes can we update the jsonexport package now?

@kaue
Copy link
Owner

kaue commented Jun 27, 2017

@dozen1488 Yes
Thanks @papswell

@kaue kaue merged commit 0735628 into kaue:master Jun 27, 2017
@dozen1488
Copy link
Author

@kauegimenes update npm package please

@kaue
Copy link
Owner

kaue commented Jun 27, 2017

@dozen1488 I can't publish, looks like there is a problem with my npm npm/npm#17463

@kaue
Copy link
Owner

kaue commented Jun 27, 2017

@papswell Can you please npm publish? just added you as a collaborator on npm

@papswell
Copy link
Collaborator

papswell commented Jun 27, 2017

@kauegimenes Im getting a 403 :(

It's strange because npm access ls-collaborators shows i have read-write access. Im not used to NPM, any idea of what i am doing wrong ? :p

@kaue
Copy link
Owner

kaue commented Jun 27, 2017

@papswell I think i have the same issue on windows, i always use mac for publish

@papswell
Copy link
Collaborator

I am on a mac. npm whoami returns papswell, so i really don't get it :(
I am using nvm, maybe it's the root of the problem ? But i have no problem to publish other packages

@papswell
Copy link
Collaborator

And today, it worked....
@dozen1488 @kauegimenes Version 2.0.10 is published :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants