-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for https://tools.ietf.org/html/rfc4180#page-3 paragraph 7 #31
Conversation
@dozen1488 Thanks for the PR! @papswell What you think about this? |
Sure, we should merge this, it makes the output more consistent, plus it fits the specs :) @dozen1488 can you give me access to your repo so that i can push the updated tests ? |
@papswell i guess i'v sent the invite. You have a push access now. |
@kauegimenes can we update the jsonexport package now? |
@dozen1488 Yes |
@kauegimenes update npm package please |
@dozen1488 I can't publish, looks like there is a problem with my npm npm/npm#17463 |
@papswell Can you please |
@kauegimenes Im getting a 403 :( It's strange because |
@papswell I think i have the same issue on windows, i always use mac for publish |
I am on a mac. |
And today, it worked.... |
@kauegimenes According to
https://tools.ietf.org/html/rfc4180#page-3
i propose to enclose strings, containing quotes, with more quotes.
Please, read https://tools.ietf.org/html/rfc4180#page-3 before approving or declining this commit.
In case of approving, please, rewrite tests.