Skip to content

Commit

Permalink
jslint fix
Browse files Browse the repository at this point in the history
  • Loading branch information
kauegimenes committed Jun 8, 2017
1 parent d4e8eb9 commit 0a269c8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 53 deletions.
56 changes: 4 additions & 52 deletions benchmark/benchmark.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
var fs = require('fs');
var util = require('util');
var Benchmark = require('benchmark');
var suite = new Benchmark.Suite;
var json2csv = require('json2csv');
var json2csvstream = new require('json2csv-stream')();
var suite = new Benchmark.Suite();
var jsonexport = require('../lib/index');
// start benchmarking
suite
Expand All @@ -20,9 +18,9 @@ suite
fs.writeFile('out-no-streams.csv', csv, function(err) {
if (err) console.log(err);
deferred.resolve();
})
})
})
});
});
});
}
})
.add('jsonexport-stream', {
Expand All @@ -46,52 +44,6 @@ suite
reader.pipe(jsonexport()).pipe(writer);
}
})
.add('json2csv', {
'defer': true,
'fn': function(deferred) {
// var data = require('./data.json');
fs.readFile('data.json', function(err, data) {
data = JSON.parse(data.toString());
if (err) console.log(err);
json2csv({
data: data,
fields: ['car', 'price', 'color']
}, function(err, csv) {
if (err) console.log(err);
fs.writeFile('out-no-streams.csv', csv, function(err) {
if (err) console.log(err);
deferred.resolve();
})
})
})
}
})
.add('json2csv-stream', {
'defer': true,
'fn': function(deferred) {
var reader = fs.createReadStream('data.json');
var writer = fs.createWriteStream('out.csv');

reader.on('error', function(err) {
console.log(err);
});

writer.on('error', function(err) {
console.log(err);
});
json2csvstream.on('end', function() {
// Wait until reader is over and then close reader and finish deferred test
writer.end();
deferred.resolve();
});



reader.pipe(json2csvstream).pipe(writer, {
end: false
});
}
})
// add listeners
.on('cycle', function(event) {
var details = event.target;
Expand Down
2 changes: 1 addition & 1 deletion lib/parser/json.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class Parser {
get headers() {
let headers = this._headers;
if (this._options.rename && this._options.rename.length > 0)
headers = headers.map((header) => this._options.rename[this._options.headers.indexOf(header)] || header)
headers = headers.map((header) => this._options.rename[this._options.headers.indexOf(header)] || header);
return headers.join(this._options.rowDelimiter);
}

Expand Down

0 comments on commit 0a269c8

Please sign in to comment.