Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Suggestion: use a minor to enable auto export #247
Thank you for this package, it really has helped me blog with ease!
I would like to suggest the following behaviour for enabling auto export - define a minor mode
This has the following benefits:
In short, it all boils down to this - it's more idiomatic to use a minor mode in this.
I have a working prototype here https://github.com/edkolev/ox-hugo/blob/use-minor-mode-to-toggle-auto-export/ox-hugo-auto-export-mode.el, I'm open to adjusting it as you see fit and opening a PR. I've signed the FSF copyright agreement.
In case you agree this is the right direction, care about backwards compatibility should be taken. Maybe the
Sorry for ignoring the issue template, this is a suggestion rather than a bug report.
Thanks for considering this!
You are welcome!
I am completely for it! See details below.
A better way would be
I agree completely.
edkolev@00ba9e5 looks great! Thanks for working on this.
Please open a PR. We can work on the fine-tuning of the commit there.
Major point: Please update the docs too (this section).
Yes. I am planning on adding a warning in that file and then removing it in the next month. But I can take care of that. In your PR, git move (rename) the
I am always up for doing the Right Thing. I was aware that minor modes are the right way to go, but somehow it didn't occur to me when I did a recent refactoring for this auto-export feature. So thank you for bringing this up.
Hello! Many thanks for bringing up this issue and doing most of the groundwork in your PR.
Everything is now committed to
You can find the details here:
Let me know if this issue can be closed (or you can do that too).