-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: use a minor to enable auto export #247
Comments
You are welcome!
I am completely for it! See details below.
A better way would be
I agree completely.
edkolev@00ba9e5 looks great! Thanks for working on this.
Awesome! 👍 Please open a PR. We can work on the fine-tuning of the commit there. Major point: Please update the docs too (this section).
Yes. I am planning on adding a warning in that file and then removing it in the next month. But I can take care of that. In your PR, git move (rename) the
No worries.
I am always up for doing the Right Thing. I was aware that minor modes are the right way to go, but somehow it didn't occur to me when I did a recent refactoring for this auto-export feature. So thank you for bringing this up. |
Nice, I didn't know this worked - I though it would change the major mode like I just submitted the PR. |
Hello! Many thanks for bringing up this issue and doing most of the groundwork in your PR. Everything is now committed to You can find the details here: Let me know if this issue can be closed (or you can do that too). |
Nice, thanks for working on this awesome project and making it even better! |
Thank you for this package, it really has helped me blog with ease!
I would like to suggest the following behaviour for enabling auto export - define a minor mode
ox-hugo-auto-export-mode
.This has the following benefits:
(require 'ox-hugo-auto-export)
needed):(require 'ox-hugo-auto-export)
in my scratch buffer, and only then go to my .org file; if I forget to run the require before opening the .org file, I have to require and then revert my .org bufferafter-save-hook
will not be polluted for all the org files the user opensIn short, it all boils down to this - it's more idiomatic to use a minor mode in this.
I have a working prototype here https://github.com/edkolev/ox-hugo/blob/use-minor-mode-to-toggle-auto-export/ox-hugo-auto-export-mode.el, I'm open to adjusting it as you see fit and opening a PR. I've signed the FSF copyright agreement.
In case you agree this is the right direction, care about backwards compatibility should be taken. Maybe the
ox-hugo-auto-export.el
file could be deprecated, but not removed. If anyone requires it, a warning would be printed. Or something along these lines.Sorry for ignoring the issue template, this is a suggestion rather than a bug report.
Thanks for considering this!
The text was updated successfully, but these errors were encountered: