Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do ast looping outside temp buf #595

Merged
merged 3 commits into from Mar 18, 2022
Merged

Conversation

kaushalmodi
Copy link
Owner

@kaushalmodi kaushalmodi commented Mar 18, 2022

Looping the AST inside an empty with-temp-buffer prevented from calling any org element functions dependent on the current (point). Separating the AST modification and temp Org buffer generation fixed this problem.

.. so that all (point) based function like
`org-hugo--get-elem-with-prop` can work during the link resolution in
the AST loop.
@kaushalmodi kaushalmodi force-pushed the do-ast-looping-outside-temp-buf branch from 4dad27e to 7d8c65f Compare March 18, 2022 05:07
@kaushalmodi kaushalmodi marked this pull request as ready for review March 18, 2022 05:17
@kaushalmodi kaushalmodi merged commit 3484e4a into main Mar 18, 2022
@kaushalmodi kaushalmodi deleted the do-ast-looping-outside-temp-buf branch March 18, 2022 05:23
kaushalmodi added a commit that referenced this pull request Mar 18, 2022
This fix was possible after the AST looping was moved outside the
`with-temp-buffer` construct:
#595

Fixes #587.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant