perf: Better way to auto-inject bibliography heading #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier method wasn't elegant because it relied on an empirically derived regexp. The reason for this change was that this regexp was falsely matching a <style> elsewhere in one of my blog posts (Nim notes), and it caused a regex out of stack error :| By advising `org-cite-export-bibliography` directly, we will always be able to perfectly inject the heading before the bibliography. As a side-effect, this approach now is able to inject the heading for non-CSS i.e. basic style bibliography as well.
[skip ci]
Adding this feature for org-ref is a bit painful because: 1. `org-ref` uses `citeproc-render-bib` in `org-ref-export.el`., while the heading insertion feature is advised to `org-cite-export-bibliography`. 2. `org-ref-process-buffer` calls `citeproc-render-bib` internally in the function and assigns the rendered bibliography to `rendered-bib` variable after manually prefixing some CSS style elements. So it's not easy to advise that internal variable. If a user wants this auto bibliography heading insertion for org-ref citations, they can use `org-export-before-parsing-hook` to post-process the Org buffer and I can help out with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier method wasn't elegant because it relied on an empirically
derived regexp. The reason for this change was that this regexp was
falsely matching a <style> elsewhere in one of my blog posts (Nim
notes), and it caused a regex out of stack error 😒
By advising
org-cite-export-bibliographydirectly, we will always beable to perfectly inject the heading before the bibliography.
As a side-effect,