fix: Escape Hugo shortcodes in description front-matter #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description front-matter will most likely be parsed as Markdown
string using $.Page.RenderString, and we do not want literal strings
like "{{< .. >}}" in there be interpreted as Hugo shortcode calls.
Shortcodes are now rendered by RenderString starting Hugo v0.100.0:
https://github.com/gohugoio/hugo/releases/tag/v0.100.0.
kaushalmodi
force-pushed
the
escape-hugo-sc-in-description-fm
branch
from
1b2d927
to
4f6517d
Compare
|
The change in this PR probably won't affect any user. The only reason this change was needed was because I literally had the Hugo shortcode braces in the description front-matter of one of the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description front-matter will most likely be parsed as Markdown
string using $.Page.RenderString, and we do not want literal strings
like "{{< .. >}}" in there be interpreted as Hugo shortcode calls.
Shortcodes are now rendered by RenderString starting Hugo v0.100.0:
https://github.com/gohugoio/hugo/releases/tag/v0.100.0.