Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matt refactor #8

Merged
merged 6 commits into from Jun 27, 2017
Merged

Conversation

titaniumbones
Copy link
Contributor

@titaniumbones titaniumbones commented Jun 27, 2017

Hi Kaushal, I've made a start on ox-hugo that does the following:

  • moves old ox-hugo.el to ox-hugo-helper.el since it's not an exporter yet.
  • moves syntax-specific changes to ox-blackfriday.el, basically copied from ox-gfm.el.. From an email thread on the org-mode mailing list, I think there may be other projects using blackfriday, the go parser on which Hugo depends. Seems like a good idea to keep this syntax stuff in its own file.
  • temporarily imports ox-hugo.el from @helloyi's repo, as a placeholder.
    • accidentally introduced some cruft. got rid of it in a later commit.
    • made some light modifications to it, though more are definitely needs.

The legacy functions aren't really an exporter, so it seems easier to
start fresh.
Hugo uses the Blackfriday markdwon parser, whose syntax is similar,
but not identical, to Github Flaboured Markdown. Since this parser may
be used by other projects, it seems like a good idea to derive
ox-hugo.el from a pure blackfriday exporter.

`ox-hugo.el` will be reserved for pure Hugo features, such as
shortcodes and frontmatter.

README updated a little, too.
Copying a lightly-modified ox-hugo.el from @helloyi's repo.
(https://github.com/helloyi/ox-hugo)
This was cruft from a previous attmept to modify ox-hugo.el.  Sorry!
Not sure why I like this better. Maybe this is stupid.
@kaushalmodi
Copy link
Owner

kaushalmodi commented Jun 27, 2017

Wow! That's a healthy dose of commits. Thank you for working on this.

The only reservations I have is licensing..

@larstvei Is it OK to take your ox-gfm.el and refactor to ox-blackfriday.el as in this PR? The file header says Copyright (C) 2014 Lars Tveito so I don't know what it means (I'm not a lawyer).

@helloyi Is it OK to take your ox-hugo.el and refactor it to use ox-blackfriday (above, also see this PR). The license says Copyright (C) 2016 Helloyi He.

In addition, would you all 3: @larstvei, @helloyi, and @titaniumbones assign the copyrights to FSF. The process is simple, just email assign@gnu.org asking that you'd like to assign your copyrights to FSF.

This is what I emailed them when I started with my FSF copyright assignment process:

Hi,

I visited this site: https://www.gnu.org/prep/maintain/html_node/Copyright-Papers.html#Copyright-Papers

I would like to contribute to GNU Emacs.

What are the copyright papers that I would need to sign and return back to you?

And the process was over in a week, all via electronic media (email and PDF attachments).

@titaniumbones
Copy link
Contributor Author

THx for catching this @kaushalmodi. I misread the GNU Emacs boilerplate at the top of both @larstvei and @helloyi's ox- files as GPL licensing. Sorry!

I have signed the FSF papers so if this makes it into Emacs my contributions are pre-approved!

@kaushalmodi
Copy link
Owner

I have signed the FSF papers so if this makes it into Emacs my contributions are pre-approved!

That's great to hear! I plan to have this in the Org source.

This was referenced Jun 27, 2017
@titaniumbones
Copy link
Contributor Author

We can keep it in MELPA until the FSF paperwork comes through though, if that's a blocker. Mine took longer to process, but that was a couple of years ago.

I filed issues larstvei/ox-gfm#22 and helloyi/ox-hugo#2, maybe the authors will respond :-)

@kaushalmodi kaushalmodi merged commit c2b9e2e into kaushalmodi:master Jun 27, 2017
@kaushalmodi
Copy link
Owner

We can keep it in MELPA until the FSF paperwork comes through though, if that's a blocker.

OK. Thanks for this PR, I have merged it.

Mine took longer to process, but that was a couple of years ago.

Probably they improved the email validation process; I got it about 2 years back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants