Created new FeedList Component #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 16
💛 - Coveralls |
Arjun-sna
reviewed
Mar 28, 2018
src/components/Home.jsx
Outdated
| @@ -22,18 +25,31 @@ class Home extends Component { | |||
| if (this.props.token && !this.props.user) { | |||
| this.props.getInfo(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
try not to push commented code
Arjun-sna
reviewed
Mar 28, 2018
src/components/FeedsList.jsx
Outdated
| import PropTypes from 'prop-types'; | ||
|
|
||
| export default function FeedList(props) { | ||
| function timeSince(date) { |
There was a problem hiding this comment.
Since this is a common function, create file name Utils.js and add these functions there so that we can reuse it.
Arjun-sna
reviewed
Mar 28, 2018
src/components/FeedsList.jsx
Outdated
| import PropTypes from 'prop-types'; | ||
|
|
||
| export default function FeedList(props) { | ||
| function timeSince(date) { |
There was a problem hiding this comment.
check if some library provides this function like moment.js or lodash
Arjun-sna
reviewed
Mar 28, 2018
src/service/httpFetch.js
Outdated
| @@ -21,6 +21,17 @@ export function getUserDetails() { | |||
| }); | |||
| } | |||
|
|
|||
|
|
|||
| export function getFeeds(username) { | |||
There was a problem hiding this comment.
Remove code duplication here. Make axios configuration common.
… \n Removed unnecessary comments from files.
Arjun-sna
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component to show logged In user's public feed.