fix: Dispatch order of Diff updates to the Adapter

Dispatch the Diff updates to the Adapter first, and then clear the Adapter's old data to load the new list.
kaushiknsanji · Oct 20, 2019 · 46ef6ab · 46ef6ab
1 parent 4ca2979
commit 46ef6ab
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/app/src/main/java/com/example/kaushiknsanji/bookslibrary/adapters/RecyclerGridAdapter.java b/app/src/main/java/com/example/kaushiknsanji/bookslibrary/adapters/RecyclerGridAdapter.java
@@ -277,13 +277,13 @@ public void swapItemData(@NonNull List<BookInfo> newBookInfos) {
      */
     private void doSwapItemData(DiffUtil.DiffResult diffResult, @NonNull List<BookInfo> newBookInfos) {
         Log.d(LOG_TAG, "doSwapItemData: Started");
+        //Informing the adapter about the changes required, so that it triggers the notify accordingly
+        diffResult.dispatchUpdatesTo(this);
+
         //Clearing the Adapter's data to load the new list of BookInfo objects
         mBookInfoList.clear();
         mBookInfoList.addAll(newBookInfos);
 
-        //Informing the adapter about the changes required, so that it triggers the notify accordingly
-        diffResult.dispatchUpdatesTo(this);
-
         //Dispatching the Item Data Swap event to the listener
         mItemDataSwapListener.onItemDataSwapped();
     }

diff --git a/app/src/main/java/com/example/kaushiknsanji/bookslibrary/adapters/RecyclerListAdapter.java b/app/src/main/java/com/example/kaushiknsanji/bookslibrary/adapters/RecyclerListAdapter.java
@@ -300,13 +300,13 @@ public void swapItemData(@NonNull List<BookInfo> newBookInfos) {
      */
     private void doSwapItemData(DiffUtil.DiffResult diffResult, @NonNull List<BookInfo> newBookInfos) {
         Log.d(LOG_TAG, "doSwapItemData: Started");
+        //Informing the adapter about the changes required, so that it triggers the notify accordingly
+        diffResult.dispatchUpdatesTo(this);
+
         //Clearing the Adapter's data to load the new list of BookInfo objects
         mBookInfoList.clear();
         mBookInfoList.addAll(newBookInfos);
 
-        //Informing the adapter about the changes required, so that it triggers the notify accordingly
-        diffResult.dispatchUpdatesTo(this);
-
         //Dispatching the Item Data Swap event to the listener
         mItemDataSwapListener.onItemDataSwapped();
     }