adding test for maxMinionLifetime

.travis.yml

@@ -1,6 +1,6 @@
 language: go
-go:
-  - 1.9.x
+# go:
+#   - 1.9.x
 env:
   - secure: ""
 

jobber/jobber_test.go

@@ -30,7 +30,8 @@ func TestJobber(t *testing.T) {
 }
 
 func TestJobber_Join(t *testing.T) {
-	j := NewJobber(Scheduler(&dummyScheduler{}), CallTimeout(time.Millisecond*300))
+	end := make(chan bool)
+	j := NewJobber(Scheduler(&dummyScheduler{}), CallTimeout(time.Millisecond*300), MaxMinionLifetime(time.Second*1))
 	d := &dummyJoinServer{send: make(chan error), receive: make(chan response)}
 	go func() {
 		j.Join(d)
@@ -41,29 +42,35 @@ func TestJobber_Join(t *testing.T) {
 		if e != nil {
 			t.Error("All was fine so expcet no error.", e, r)
 		}
+		end <- true
 	}()
 	d.send <- nil
 	d.receive <- response{result: &payload.Result{}, err: nil}
+	<-end
 
 	// wait 2 *CallTimeout to make sure call will timeout
 	go func() {
 		r, e := j.Do(&payload.Task{})
 		if e == nil || e.Error() != "timeout" {
 			t.Error("Call should have been timedout.", r)
 		}
+		end <- true
 	}()
 	time.Sleep(time.Millisecond * 600)
 	d.send <- nil
 	d.receive <- response{result: &payload.Result{}, err: nil}
+	<-end
+
 	// error on send
 	go func() {
 		_, e := j.Do(&payload.Task{})
 		if e.Error() != "send_error" {
 			t.Error("expected error.", e)
 		}
+		end <- true
 	}()
 	d.send <- errors.New("send_error")
-	// d.receive <- response{result: &payload.Result{}, err: nil}
+	<-end
 
 	// function will exit on send error
 	d1 := &dummyJoinServer{send: make(chan error), receive: make(chan response)}
@@ -77,10 +84,24 @@ func TestJobber_Join(t *testing.T) {
 		if e.Error() != "receive_error" {
 			t.Error("expected error.", e)
 		}
+		end <- true
 	}()
 	d1.send <- nil
 	d1.receive <- response{result: &payload.Result{}, err: errors.New("receive_error")}
+	<-end
 
-	time.Sleep(time.Second)
+	j.maxMinionLifetime = time.Millisecond * 100
+	// check if MaxMinionLifetime take effect
+	d2 := &dummyJoinServer{send: make(chan error), receive: make(chan response)}
+	go func() {
+		j.Join(d2)
+		end <- true
+	}()
+
+	select {
+	case <-end:
+	case <-time.After(time.Second * 1):
+		t.Error("Join was still running even after MaxMinionLifetime")
+	}
 
 }