Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove circular deps #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove circular deps #111

wants to merge 1 commit into from

Conversation

pkit
Copy link

@pkit pkit commented Feb 8, 2020

No description provided.

@kawanet
Copy link
Owner

kawanet commented Feb 12, 2020

Thank you for the PR. Bufferish is one of the most of complex parts of the library.
I have had a plan to make it simpler and smarter, but it was almost canceled as I recently don't have enough time to maintain this. I'll check it later! 😄

@pkit
Copy link
Author

pkit commented Feb 12, 2020

Unfortunately there are problems with older nodejs versions.
Because the class mangling in these parts is insane.
I will try to make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pkit @kawanet