Exposed createEncodeStream and createDecodeStream #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey kawanet!
Here at keybase, we've been using
msgpack-lite
for a few weeks in one of our projects. Long story short, we need streaming msgpack encoding and decoding per our encryption spec, and your library has been a breeze to use. Recently, we finished up testing on server side within node and are working on the browser side, where we quickly encountered a problem: themsgpack.min.js
file doesn't expose thecreateEncodeStream
andcreateDecodeStream
functions. Here I've done nothing more than expose them inbrowser.js
, which fixes our issues.We can maintain our own fork of
msgpack-lite
, but I figured it would be easier to have it upstream for such a small change, and that way we don't have to worry about versioning in the future. I appreciate that my change inflates the size ofmsgpack.min.js
to 89K, so if you feel that that's an issue, I can definitely separate this out into two.min.js
files, the original and this new one.Thanks for your time!
Mark and the Keybase team