This repository has been archived by the owner on Jun 29, 2020. It is now read-only.
Support shorten YouTube URL closes #1102 #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdalisue
suggested changes
Nov 23, 2016
| @@ -4,7 +4,7 @@ | |||
|
|
|||
|
|
|||
| PATTERN = re.compile( | |||
| r"https?://www\.youtube\.com/watch\?v=(?P<id>[a-zA-Z0-9_\-]+)" | |||
| r"https?://(www\.youtube\.com/watch\?v=|youtu\.be\/)(?P<id>[a-zA-Z0-9_\-]+)" | |||
There was a problem hiding this comment.
あとで利用しないならグルーピングは不要かな。あと / のエスケープも不要だと思う。
https?://(?:www\.youtube\.com/watch\?v=|youtu\.be/)(...)
| @@ -25,6 +25,12 @@ def test_parse_youtube_urls(self): | |||
| value = parse_youtube_urls(value) | |||
| self.assertEqual(value, self._render_template(self.video_id)) | |||
|
|
|||
| def test_parse_shorten_youtube_urls(self): | |||
| """短縮されたYouTubeのURLは展開される""" | |||
|
なおした |
|
バックスラッシュのエスケープ必要？ |
|
なおしました |
|
さすがに良さそうだからマージ |
|
lgtm! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1102
@Clpsplug @lambdalisue レビューお願いします