Skip to content
This repository has been archived by the owner on Jun 29, 2020. It is now read-only.

イベント参加者がイベント編集できるように #1144

Merged
merged 3 commits into from
Mar 19, 2017
Merged

イベント参加者がイベント編集できるように #1144

merged 3 commits into from
Mar 19, 2017

Conversation

miio
Copy link
Member

@miio miio commented Mar 4, 2017 •
edited by giginet
Loading

closes #1143

@miio
Copy link
Member Author

miio commented Mar 4, 2017

viewのテストは「EventUpdateViewTestCase」にattendee生やしてテストするのが正解そうかねぇ？

@coveralls
Copy link

coveralls commented Mar 4, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 97.696% when pulling d5bbadc on miio/event-edit-attendee into 630bb06 on develop.

giginet
giginet suggested changes Mar 10, 2017
View reviewed changes
Copy link
Member

@giginet giginet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kawazrepos/Kawaz3rd/pull/1144/files#diff-a73b442d12fe93f0e37c807c2eacc6d4R95

attendeeが削除できないことをこの辺にテスト追加してもらって良いですか？

@giginet
Copy link
Member

giginet commented Mar 10, 2017

変更は良さそう。

この辺のテストが全然変更されてないことを見るに、テストが薄そうなので、一度これはマージして、後日テストを追加しておきたい

@coveralls
Copy link

coveralls commented Mar 19, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 97.696% when pulling 7ba6817 on miio/event-edit-attendee into 828fbc2 on develop.

@coveralls
Copy link

coveralls commented Mar 19, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 97.696% when pulling 7ba6817 on miio/event-edit-attendee into 828fbc2 on develop.

@giginet giginet merged commit 8a41e59 into develop Mar 19, 2017
@giginet giginet deleted the miio/event-edit-attendee branch March 19, 2017 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giginet giginet giginet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@miio @coveralls @giginet