Add up_to_date_checker.js #3
Conversation
This will check if the PR branch is up to date with master based on modified files in the PR similar to the labeller.js
|
@potiuk @kaxil Please take a look. The config will look something like this. xinbinhuang/airflow@cd2b086 And this is an example PR xinbinhuang/airflow#7 |
Awesome, thanks for the PR @xinbinhuang . Reviewing it now |
There was a problem hiding this comment.
If possible, can you add some docs around this awesome feature @xinbinhuang in https://github.com/kaxil/boring-cyborg/blob/master/README.md#features
and Config in https://github.com/kaxil/boring-cyborg/blob/master/README.md#usage
lib/up_to_date_checker.js
Outdated
| const ignore = require('ignore') | ||
|
|
||
| /** | ||
| * Check branch up to date with master if specific files are modified in the PR |
There was a problem hiding this comment.
| * Check branch up to date with master if specific files are modified in the PR | |
| * Check branch is up to date with master if specific files are modified in the PR |
There was a problem hiding this comment.
I rephrased the docstring. I hope it's more readable right now.
Added^. Please take a look. After this is merged, I will also submit a PR to the bot setting. Do you think the config example is good? |
Yup, it is definitely good. Well done @xinbinhuang 🎉 |
|
Thanks @kaxil ! |
This component will check if the PR is up to date with master only if certain files specified in the config are modified as discussed in the mail thread.