Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forgetting to pass --config argument causes strange error #307

Closed
aereal opened this issue Jul 21, 2021 · 1 comment
Closed

forgetting to pass --config argument causes strange error #307

aereal opened this issue Jul 21, 2021 · 1 comment

Comments

@aereal
Copy link
Contributor

aereal commented Jul 21, 2021

Way to reproduce

Run ecspresso init with required arguments except --config.

Expected behavior

No errors happen or enough information to fix it such as --config required but not passed.

Actual Behavior

Got failed to write file: open : no such file or directory error.

Full error messages are below:

[2021-07-21 13:55:58] ✘╹◡╹✘ < ecspresso init --cluster $cluster_arn --service $service_arn
2021/07/21 13:56:06 <snip> save service definition to ecs-service-def.json
2021/07/21 13:56:06 <snip> save task definition to ecs-task-def.json
2021/07/21 13:56:06 <snip> save config to
2021/07/21 13:56:06 init FAILED. failed to write file: open : no such file or directory

Way to fix

I think --config argument is actually a required parameter so it must be marked as a required parameter using .Required(), or should we set a default value such as config.yml?

@aereal aereal changed the title forgetting to pass --conf argument causes strange error forgetting to pass --config argument causes strange error Jul 21, 2021
aereal added a commit to aereal/ecspresso that referenced this issue Jul 21, 2021
@aereal
Copy link
Contributor Author

aereal commented Jul 31, 2021

Fixed by #308

@aereal aereal closed this as completed Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant