Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add revision option to deploy command #672

Merged

Conversation

tksx1227
Copy link
Contributor

@tksx1227 tksx1227 commented Mar 2, 2024

issue

description

  • Add revision option to DeployOption.
  • Dependencies or conflicts between options make an error.
  • Extract the logic for finding the task-definition arn as a method.

deploy.go Outdated Show resolved Hide resolved
@fujiwara
Copy link
Contributor

fujiwara commented Mar 6, 2024

@tksx1227 Thank you for the great feature!

Certainly, ecspresso run has the --revision option, it is also helpful for deploy. Please check a review comment.

Co-authored-by: FUJIWARA Shunichiro <fujiwara.shunichiro@gmail.com>
@tksx1227 tksx1227 requested a review from fujiwara March 6, 2024 05:54
@tksx1227
Copy link
Contributor Author

tksx1227 commented Mar 6, 2024

@fujiwara
Thank you for your review comment!
I have corrected the problem, please check again.

@fujiwara fujiwara merged commit 9b9cc40 into kayac:v2 Mar 6, 2024
2 checks passed
@fujiwara
Copy link
Contributor

fujiwara commented Mar 6, 2024

@tksx1227 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants