Skip to content

Commit

Permalink
Removing the check for str in the _format_data_point functions. Strin…
Browse files Browse the repository at this point in the history
…g values should just fall through the whole function.
  • Loading branch information
twheys committed Aug 23, 2016
1 parent 17b7678 commit 50c44f4
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
3 changes: 0 additions & 3 deletions fireant/slicer/transformers/datatables.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@


def _format_data_point(value):
if isinstance(value, str):
return str(value)

if isinstance(value, pd.Timestamp):
if value.time() == NO_TIME:
return value.strftime('%Y-%m-%d')
Expand Down
2 changes: 0 additions & 2 deletions fireant/slicer/transformers/highcharts.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@


def _format_data_point(value):
if isinstance(value, str):
return value
if isinstance(value, pd.Timestamp):
return int(value.asm8) // int(1e6)
if value is None or (isinstance(value, float) and np.isnan(value)):
Expand Down

0 comments on commit 50c44f4

Please sign in to comment.