Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for the generated aliases #159

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Fixes for the generated aliases #159

merged 1 commit into from
Jul 5, 2018

Conversation

twheys
Copy link
Contributor

@twheys twheys commented Jul 5, 2018

Prepended a $ character to all aliases to avoid collisions with column names

@twheys twheys self-assigned this Jul 5, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 92.396% when pulling 3bd0f98 on fix_aliases into 71f8f56 on fireant1.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 92.396% when pulling 3bd0f98 on fix_aliases into 71f8f56 on fireant1.0.

@coveralls
Copy link

coveralls commented Jul 5, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 92.396% when pulling 3bd0f98 on fix_aliases into 71f8f56 on fireant1.0.

@twheys twheys merged commit 2356429 into fireant1.0 Jul 5, 2018
@twheys twheys deleted the fix_aliases branch July 5, 2018 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeengland mikeengland mikeengland approved these changes

@x8lucas8x x8lucas8x Awaiting requested review from x8lucas8x

@inkmix inkmix Awaiting requested review from inkmix

@wahwynn wahwynn Awaiting requested review from wahwynn

Assignees

@twheys twheys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twheys @coveralls @mikeengland