Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix col index tables #162

Merged
merged 1 commit into from Jul 9, 2018
Merged

Fix col index tables #162

merged 1 commit into from Jul 9, 2018

Conversation

twheys
Copy link
Contributor

@twheys twheys commented Jul 9, 2018

Data tables would break any time a third dimension was added for two bugs

  • The order of the dimensions did not match in the column definition and the data
  • A column definition was created for every combination of dimension values instead of just the ones in the data frame.

@twheys
Fixed the pivoted data tables widgets to render the data in the corre…
d661a26 
…ct dimension order and removed column definitions for dimension value combinations that do not exist in the data frame.
@twheys twheys changed the base branch from master to fireant1.0 July 9, 2018 09:17
@mikeengland mikeengland merged commit 871cd6d into fireant1.0 Jul 9, 2018
@coveralls
Copy link

coveralls commented Jul 9, 2018 •
edited

Coverage Status

Coverage decreased (-0.06%) to 93.526% when pulling d661a26 on fix_col_index_tables into 49b0368 on fireant1.0.

@twheys twheys deleted the fix_col_index_tables branch December 13, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeengland mikeengland mikeengland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twheys @coveralls @mikeengland