Added special case for using rolling operations with date filters/dimensions #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeengland
reviewed
Jul 10, 2018
| from fireant.slicer.operations import RollingOperation | ||
|
|
||
|
|
||
| def adjust_daterange_filter_for_rolling_window(dimensions, operations, filters): |
There was a problem hiding this comment.
These functions could do with comments explaining why the date range has to be adjusted
There was a problem hiding this comment.
ok will do. Just hope I can find a better solution for this at some point because right now we need to jump through a lot of hoops to figure it out.
…d date filter in order to adjust the filter then truncate the resulting data frame
twheys
force-pushed
the
rolling_op_special_cases
branch
from
057a750
to
9807d07
Compare
mikeengland
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added special case for using rolling operation with date dimension and date filter in order to adjust the filter then truncate the resulting data frame