New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReactTable sorting with NaNs #181

Merged

twheys merged 1 commit into fireant1.0 from fix_sorting_with_nans_pandas

Aug 29, 2018

Contributor

twheys commented Aug 29, 2018

Fixed react table transformer to sort with NaN values in the column by moving the fillna part after the sort


          Fixed react table transformer to sort with NaN values in the column b…

029f157

…y moving the fillna part after the sort

twheys self-assigned this

coveralls commented Aug 29, 2018

Coverage increased (+0.004%) to 93.097% when pulling 029f157 on fix_sorting_with_nans_pandas into 90b9456 on fireant1.0.

mikeengland approved these changes

View reviewed changes

twheys merged commit 93cc081 into fireant1.0

twheys deleted the fix_sorting_with_nans_pandas branch

August 29, 2018 15:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment