Fixed sorting data frames with no dimensions #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sformer when there are no dimensions
x8lucas8x
approved these changes
Sep 11, 2018
| @@ -121,7 +121,7 @@ def pivot_data_frame(self, data_frame, pivot=(), transpose=False): | |||
| .fillna(value='') | |||
|
|
|||
| def sort_data_frame(self, data_frame): | |||
| if not self.sort: | |||
| if not self.sort or len(data_frame) == 1: | |||
There was a problem hiding this comment.
What's the implication of having len(data_frame) == 1 here? Perhaps it'd be better to have a variable named has_some_property or is_some_property, which would be used in this if, so that people know why len(data_frame) == 1 must return the dataframe.
There was a problem hiding this comment.
This is quite literal. If the data frame has one row, then sorting it would not yield any effect. I can add a comment.
…orting is not required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed another issue related to sorting data frames in the pandas transformer when there are no dimensions