Matplotlib widget #189
Merged
Matplotlib widget #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeengland
reviewed
Sep 13, 2018
| stacking = 'percent' | ||
|
|
||
|
|
||
| class HighChartsPieChartTransformerTests(TestCase): | ||
| maxDiff = None | ||
|
|
||
| chart_class = HighCharts.PieChart | ||
| chart_class = HighCharts.PieSeries |
There was a problem hiding this comment.
Personal preference - but I think the name PieChart makes more sense to use than PieSeries.
There was a problem hiding this comment.
It's a series because there are multiple series within the same Chart. I changed the name to disambiguate it.
mikeengland
approved these changes
Sep 13, 2018
twheys
force-pushed
the
matplotlib_widget
branch
from
aa6343b
to
fd0c571
Compare
gl3nn
approved these changes
Sep 13, 2018
…p matplotlib tests if matplotlib is not installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a matplotlib widget.
The tests are a bit bare because I'm not sure how to evaluate the matplotlib objects. Will come back to that later.