Support for Hyperlink Templates on Dimensions #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twheys
force-pushed
the
hyperlink_template_dimensions
branch
from
b6b6860
to
cb09711
Compare
…he reacttable widget
twheys
force-pushed
the
hyperlink_template_dimensions
branch
from
cb09711
to
80cf07f
Compare
wahwynn
reviewed
Nov 14, 2018
fireant/slicer/widgets/reacttable.py
Outdated
| @staticmethod | ||
| def map_hyperlink_templates(df, dimensions): | ||
| """ | ||
| WRITEME |
There was a problem hiding this comment.
Could you please add this header comment now rather than later.
wahwynn
approved these changes
Nov 14, 2018
mikeengland
approved these changes
Nov 14, 2018
| def map_hyperlink_templates(df, dimensions): | ||
| """ | ||
| WRITEME | ||
|
|
There was a problem hiding this comment.
Looks like this docstring is still to be written
fireant/slicer/widgets/reacttable.py
Outdated
| arguments = [format_dimension_key(argument[1:-1]) | ||
| for argument in pattern.findall(hyperlink_template)] | ||
| missing_dimensions = set(arguments) & set(df.index.names) | ||
| if not missing_dimensions: |
There was a problem hiding this comment.
Minor but I think this could have a clearer name. Instead of missing_dimensions this could be dimensions_to_hyperlink or something.
There was a problem hiding this comment.
Could rename it to unavailable_hyperlink_parameters. This is a set of the dimensions required to fill in the hyperlink template that are not in the result data set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for hyperlink templates in dimensions which work with the reacttable widget