Fixed some deepcopy issues #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is triggered via @immutable function in an instance of DataSet or Widget. Fixed some issues where the ability to use "is" comparison on fields made things a lot cleaner. Got rid of some field copying in some tests.
gl3nn
approved these changes
Jan 6, 2020
…have overlapping field aliases
…ck in __getattr__ for these attributes that raises an AttributeError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues with deepcopy so that Fields are cached when a deepcopy is triggered via @immutable function in an instance of DataSet or Widget.
Fixed some issues where the ability to use "is" comparison on fields made things a lot cleaner.
Got rid of some field copying in some tests.