Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed delta reference calculation to work when their are null values for a dimension #273

Merged
merged 1 commit into from Jan 13, 2020

Conversation

twheys
Copy link
Contributor

@twheys twheys commented Jan 13, 2020

fixed the subtraction of reference values to work around an issue with pandas where nans in the index lead to duplication

…h pandas where nans in the index lead to duplication
@twheys twheys requested a review from a team as a code owner January 13, 2020 13:41
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 90.388% when pulling b25a64d on fix_delta_reference_with_null_dimension_val into d68965b on master.

@twheys twheys merged commit 9b55b3d into master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants