Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data blending dimensions #277

Merged
merged 1 commit into from Jan 21, 2020
Merged

Data blending dimensions #277

merged 1 commit into from Jan 21, 2020

Conversation

twheys
Copy link
Contributor

@twheys twheys commented Jan 21, 2020

Per feedback, all dimensions should be usable with data blending, but the join should be based on mapped dimensions. Changed the behavior of data blending to allow all dimensions to be selected regardless of whether they are mapped

@twheys
Changed the behavior of data blending to allow all dimensions to be s…
aaf04ed 
…elected regardless of whether they are mapped
@twheys twheys requested a review from a team as a code owner January 21, 2020 15:25
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 90.502% when pulling aaf04ed on data_blending_no_dimension_restriction into c486206 on master.

@twheys twheys merged commit 8cc95b6 into master Jan 21, 2020
@twheys twheys deleted the data_blending_no_dimension_restriction branch January 21, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gl3nn gl3nn gl3nn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twheys @coveralls @gl3nn