Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid outer join for postgresql #95

Closed
abondar opened this issue Dec 29, 2017 · 1 comment
Closed

Invalid outer join for postgresql #95

abondar opened this issue Dec 29, 2017 · 1 comment

Comments

@abondar
Copy link
Contributor

abondar commented Dec 29, 2017

Current join enum have only basic "OUTER" join, which is not supported by postgresql.
how parameter for joins should accept list of JoinType's, so join could be concatenated, or JoinType enum should be extended to have `LEFT OUTER' 'RIGHT OUTER' 'FULL OUTER'.

I can implement it, but would like to hear your opinion on this matter, may be I am missing something, how joins should be built with pypika

@twheys
Copy link
Contributor

twheys commented Jan 5, 2018

Thanks for reporting. This is a really small fix so I just raised a PR. To keep it simple I just added enum values for these three, since not every combination is possible, and since the list of join types is quite small and manageable.

@twheys twheys closed this as completed in 7c22104 Jan 8, 2018
twheys added a commit that referenced this issue Jan 8, 2018
Fixes #95 Added left outer, right outer, and full outer as join types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants