Add proper retry support when transient errors occur #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase min wait retry time to 1 second.
in FacebookBatch.
Pull Request Test Coverage Report for Build 29
💛 - Coveralls |
mikeengland
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the retry behaviour to retry all requests that had transient errors, instead of only doing that when all failures were transient. Besides, transient errors now include not only what facebook classifies as is_transient, but also all 500 requests, given not all 500 requests from facebook have is_transient in the payload.
As part of this PR I have reformatted everything with black and added pre-commit hooks to run it on commit. A flake8 plugin was also added to check whether code is black formatted.