Skip to content

Commit

Permalink
Merge pull request NOAA-GSL#34 from NOAA-EMC/develop
Browse files Browse the repository at this point in the history
Sync develop branch with EMC develop
  • Loading branch information
jderrico-noaa committed Dec 11, 2023
2 parents 9f7eeba + 29d3417 commit 4562dec
Show file tree
Hide file tree
Showing 2,016 changed files with 95,758 additions and 144,541 deletions.
29 changes: 29 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# EditorConfig helps developers define and maintain consistent
# coding styles between different editors and IDEs
# editorconfig.org

root = true


[*]
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
indent_style = space
indent_size = 2

[*.py]
indent_size = 4
max_line_length = 88

[*.txt]
indent_style = tab
indent_size = 4
max_line_length = 79

[*.{diff}]
trim_trailing_whitespace = false

[Makefile]
indent_style = tab
66 changes: 66 additions & 0 deletions .github/ISSUE_TEMPLATE/NCO_bug_report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
name: NCO Bug report
description: Report something that is incorrect or broken
labels: ["nco-bug", "triage"]
assignees:
- aerorahul

body:
- type: markdown
attributes:
value: |
Your bug may already be reported!
Please search on the [Issue tracker](https://github.com/NOAA-EMC/global-workflow/issues) before creating one.
- type: textarea
id: current_behavior
attributes:
label: What is wrong?
description: Give a brief description of what is incorrect or broken.
placeholder: |
Short log snippets that illustrate the problem can be included here.
For any longer logs, please create a GitHub gist (https://gist.github.com/) and link it here.
validations:
required: true

- type: textarea
id: expected_behavior
attributes:
label: What should have happened?
placeholder: Describe what you expected to happen.
validations:
required: true

- type: textarea
id: reproduction_steps
attributes:
label: Steps to reproduce
description: Please give explicit instructions to reproduce the error
placeholder: |
1.
2.
3.
validations:
required: true

- type: input
id: bugzilla
attributes:
label: Bugzilla issue
description: What is the corresponding NCO bugzilla issue number?
placeholder: "#..."

- type: textarea
id: description
attributes:
label: Additional information
description: Provide context or any additional information about the bug.
validations:
required: true

- type: textarea
id: proposed_implementation
attributes:
label: Do you have a proposed solution?
description: If you already have an idea on how to fix this, please provide it here.
placeholder: Optional
75 changes: 75 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
name: Bug report
description: Report something that is incorrect or broken
labels: ["bug", "triage"]

body:
- type: markdown
attributes:
value: |
Your bug may already be reported!
Please search on the [Issue tracker](https://github.com/NOAA-EMC/global-workflow/issues) before creating one.
- type: textarea
id: current_behavior
attributes:
label: What is wrong?
description: Give a brief description of what is incorrect or broken.
placeholder: |
Short log snippets that illustrate the problem can be included here.
For any longer logs, please create a GitHub gist (https://gist.github.com/) and link it here.
validations:
required: true

- type: textarea
id: expected_behavior
attributes:
label: What should have happened?
placeholder: Describe what you expected to happen.
validations:
required: true

- type: dropdown
id: hpc
attributes:
label: What machines are impacted?
description: You may select multiple machines.
multiple: true
options:
- All or N/A
- WCOSS2
- Hera
- Orion
- Jet
- Cloud
validations:
required: true

- type: textarea
id: reproduction_steps
attributes:
label: Steps to reproduce
description: Please give explicit instructions to reproduce the error
placeholder: |
1.
2.
3.
validations:
required: true

- type: textarea
id: description
attributes:
label: Additional information
description: Provide context or any additional information about the bug.
validations:
required: true

- type: textarea
id: propsed_implementation
attributes:
label: Do you have a proposed solution?
description: If you already have an idea on how to fix this, please provide it here.
placeholder: Optional
validations:
required: false
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
blank_issues_enabled: false
55 changes: 55 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
name: Feature request
description: Request new capability
labels: ["feature", "triage"]

body:
- type: markdown
attributes:
value: |
If your issue falls into one of the follow categories, please go back and use the appropriate template:
- Something is wrong or broken
- It is a request from NCO
- It is initiating a production update
- Files need to be updated or added to fix
Please search on the [Issue tracker](https://github.com/NOAA-EMC/global-workflow/issues) to make sure the feature has not already been requested to avoid duplicates.
- type: textarea
id: description
attributes:
label: What new functionality do you need?
placeholder: Provide a consise description of the problem to be addressed by this feature request. Please be clear what parts of the problem are considered to be in-scope and out-of-scope
validations:
required: true

- type: textarea
id: requirements
attributes:
label: What are the requirements for the new functionality?
validations:
required: true

- type: textarea
id: criteria
attributes:
label: Acceptance Criteria
placeholder: What does it mean for this issue to be complete?
validations:
required: true

- type: textarea
id: suggested_solution
attributes:
label: Suggest a solution (optional)
placeholder: |
Propose how this issue can be resolved.
Things to address include:
* Details of the technical implementation
* Tradeoffs made in design decisions
* Caveats and considerations for the future
If there are multiple solutions, please present each one separately. Save comparisons for the very end.)"
validations:
required: false
97 changes: 97 additions & 0 deletions .github/ISSUE_TEMPLATE/fix_file.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
name: Fix File Update
description: Request fix files be added or updated
labels: ["Fix Files", "triage"]
assignees:
- KateFriedman-NOAA
- WalterKolczynski-NOAA

body:
- type: dropdown
attributes:
label: Target fix directory
options:
- NEW
- aer
- am
- chem
- cice
- cpl
- datm
- gdas/crtm
- gdas/fv3jedi
- gdas/gsibec
- gldas
- glwu
- gsi
- lut
- mom6
- orog
- raw
- reg2grb2
- sfc_climo
- ugwd
- verif
- wave
multiple: true
validations:
required: true

- type: checkboxes
attributes:
label: Type of change
options:
- label: Update existing files
- label: Remove files
- label: Add new files to existing directory
- label: Add new fix directory
validations:
required: true

- type: dropdown
attributes:
label: Any workflow changes needed?
description: |
Any change other than adding files to an existing directory will require at least a new fix version.
options:
- No change needed
- Fix version only
- Fix version + additional changes
validations:
required: true

- type: textarea
attributes:
label: Related issues
description: Please link any related issues in other repositories
placeholder: NOAA-EMC/repo#1234
validations:
required: false

- type: input
attributes:
label: Pickup location
description: |
Please provide a path to the data on either Hera or WCOSS.
If this requires a version update, please provide the *entire* directory, including unchanged files from current fix.
placeholder: '/path/to/new/fix'
validations:
required: true

- type: input
attributes:
label: Size
description: How much bigger/smaller is the new set from the existing set (in MB)?
placeholder: '0'
validations:
required: true

- type: markdown
attributes:
value: |
# Tasks
- [ ] Discuss needs with global-workflow developer assigned to request.
- [ ] Add/update/remove fix file(s) in fix sets on supported platforms (global-workflow assignee task).
- [ ] Update "Fix File Management" spreadsheet (https://docs.google.com/spreadsheets/d/1BeIvcz6TO3If4YCqkUK-oz_kGS9q2wTjwLS-BBemSEY/edit?usp=sharing).
- [ ] Make related workflow/component updates.
50 changes: 50 additions & 0 deletions .github/ISSUE_TEMPLATE/production_update.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
name: Production Update
description: Begin the process of an operational production update
labels: ["production update", "triage"]
assignees:
- WalterKolczynski-NOAA
- KateFriedman-NOAA

body:
- type: textarea
id: description
attributes:
label: Description
description: Provide a concise description of the production update.
placeholder: Include related issues in component repositories.
validations:
required: true

- type: input
id: target
attributes:
label: Target version
description: What is the target GFS version?
placeholder: Use v#.#.# format
validations:
required: true

- type: textarea
id: changes
attributes:
label: Expected workflow changes
description: What are the anticipated changes coming into the workflow?
placeholder: Include version variables, checkout tags, config/parm, etc.
validations:
required: true

- type: markdown
attributes:
value: |
** Tasks **
- [ ] Create release branch
- [ ] Make workflow changes for upgrade in release branch (add additional checklist items as needed)
- [ ] Create release notes
- [ ] Cut hand-off tag for CDF
- [ ] Submit CDF to NCO
- [ ] Implementation into operations complete
- [ ] Merge release branch into operational branch
- [ ] Cut version tag from operational branch
- [ ] Release new version tag
- [ ] Announce to users
- [ ] Update Read-The-Docs operations status version in develop
Loading

0 comments on commit 4562dec

Please sign in to comment.