Skip to content

Commit

Permalink
Consolidate npe_node_max (NOAA-EMC#2289)
Browse files Browse the repository at this point in the history
- The environment variable `npe_node_max` is removed from all
files beneath `global-workflow/env`;
- The environment variable `npe_node_max` is removed from
`parm/config/gefs/config.ufs` and `parm/config/gfs/config.ufs`;
- The environment variable `npe_node_max` is maintained only
within `parm/config/gefs/config.resources` and
`parm/config/gfs/config.resources`.

Resolves NOAA-EMC#2133
  • Loading branch information
HenryRWinterbottom committed Feb 7, 2024
1 parent b0325e0 commit 801058f
Show file tree
Hide file tree
Showing 10 changed files with 0 additions and 116 deletions.
1 change: 0 additions & 1 deletion env/AWSPW.env
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ fi

step=$1

export npe_node_max=36
export launcher="mpiexec.hydra"
export mpmd_opt=""

Expand Down
1 change: 0 additions & 1 deletion env/CONTAINER.env
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ fi

step=$1

export npe_node_max=40
export launcher="mpirun"
export mpmd_opt="--multi-prog"

Expand Down
1 change: 0 additions & 1 deletion env/HERA.env
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ fi

step=$1

export npe_node_max=40
export launcher="srun -l --export=ALL"
export mpmd_opt="--multi-prog --output=mpmd.%j.%t.out"

Expand Down
1 change: 0 additions & 1 deletion env/HERCULES.env
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ fi

step=$1

export npe_node_max=80
export launcher="srun -l --export=ALL"
export mpmd_opt="--multi-prog --output=mpmd.%j.%t.out"

Expand Down
7 changes: 0 additions & 7 deletions env/JET.env
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,6 @@ fi

step=$1

if [[ "${PARTITION_BATCH}" = "xjet" ]]; then
export npe_node_max=24
elif [[ "${PARTITION_BATCH}" = "vjet" ]]; then
export npe_node_max=16
elif [[ "${PARTITION_BATCH}" = "kjet" ]]; then
export npe_node_max=40
fi
export launcher="srun -l --epilog=/apps/local/bin/report-mem --export=ALL"
export mpmd_opt="--multi-prog --output=mpmd.%j.%t.out"

Expand Down
1 change: 0 additions & 1 deletion env/ORION.env
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ fi

step=$1

export npe_node_max=40
export launcher="srun -l --export=ALL"
export mpmd_opt="--multi-prog --output=mpmd.%j.%t.out"

Expand Down
6 changes: 0 additions & 6 deletions env/S4.env
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,7 @@ if [[ $# -ne 1 ]]; then
fi

step=$1
PARTITION_BATCH=${PARTITION_BATCH:-"s4"}

if [[ ${PARTITION_BATCH} = "s4" ]]; then
export npe_node_max=32
elif [[ ${PARTITION_BATCH} = "ivy" ]]; then
export npe_node_max=20
fi
export launcher="srun -l --export=ALL"
export mpmd_opt="--multi-prog --output=mpmd.%j.%t.out"

Expand Down
2 changes: 0 additions & 2 deletions env/WCOSS2.env
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ step=$1
export launcher="mpiexec -l"
export mpmd_opt="--cpu-bind verbose,core cfp"

export npe_node_max=128

if [[ "${step}" = "prep" ]] || [[ "${step}" = "prepbufr" ]]; then

nth_max=$((npe_node_max / npe_node_prep))
Expand Down
48 changes: 0 additions & 48 deletions parm/config/gefs/config.ufs
Original file line number Diff line number Diff line change
Expand Up @@ -68,54 +68,6 @@ if [[ "${skip_mom6}" == "false" ]] || [[ "${skip_cice6}" == "false" ]] || [[ "${
skip_mediator=false
fi

case "${machine}" in
"WCOSS2")
npe_node_max=128
;;
"HERA" | "ORION" )
npe_node_max=40
;;
"HERCULES" )
npe_node_max=80
;;
"JET")
case "${PARTITION_BATCH}" in
"xjet")
npe_node_max=24
;;
"vjet" | "sjet")
npe_node_max=16
;;
"kjet")
npe_node_max=40
;;
*)
echo "FATAL ERROR: Unsupported ${machine} PARTITION_BATCH = ${PARTITION_BATCH}, ABORT!"
exit 1
;;
esac
;;
"S4")
case "${PARTITION_BATCH}" in
"s4")
npe_node_max=32
;;
"ivy")
npe_node_max=20
;;
*)
echo "FATAL ERROR: Unsupported ${machine} PARTITION_BATCH = ${PARTITION_BATCH}, ABORT!"
exit 1
;;
esac
;;
*)
echo "FATAL ERROR: Unrecognized machine ${machine}"
exit 14
;;
esac
export npe_node_max

# (Standard) Model resolution dependent variables
case "${fv3_res}" in
"C48")
Expand Down
48 changes: 0 additions & 48 deletions parm/config/gfs/config.ufs
Original file line number Diff line number Diff line change
Expand Up @@ -68,54 +68,6 @@ if [[ "${skip_mom6}" == "false" ]] || [[ "${skip_cice6}" == "false" ]] || [[ "${
skip_mediator=false
fi

case "${machine}" in
"WCOSS2")
npe_node_max=128
;;
"HERA" | "ORION" )
npe_node_max=40
;;
"HERCULES" )
npe_node_max=80
;;
"JET")
case "${PARTITION_BATCH}" in
"xjet")
npe_node_max=24
;;
"vjet" | "sjet")
npe_node_max=16
;;
"kjet")
npe_node_max=40
;;
*)
echo "FATAL ERROR: Unsupported ${machine} PARTITION_BATCH = ${PARTITION_BATCH}, ABORT!"
exit 1
;;
esac
;;
"S4")
case "${PARTITION_BATCH}" in
"s4")
npe_node_max=32
;;
"ivy")
npe_node_max=20
;;
*)
echo "FATAL ERROR: Unsupported ${machine} PARTITION_BATCH = ${PARTITION_BATCH}, ABORT!"
exit 1
;;
esac
;;
*)
echo "FATAL ERROR: Unrecognized machine ${machine}"
exit 14
;;
esac
export npe_node_max

# (Standard) Model resolution dependent variables
case "${fv3_res}" in
"C48")
Expand Down

0 comments on commit 801058f

Please sign in to comment.