Skip to content

Commit

Permalink
Fix rocoto forecast hour determination for GEFS (NOAA-EMC#2351)
Browse files Browse the repository at this point in the history
The function that generates the list of forecast hours for rocoto was
trying to use variables that are not defined for GEFS, causing workflow
generation to fail. The function is updated to not try to load these
variables before loading the ones actually used for GFS/ GEFS.

Also turns GEFS CI test back on and adds an entry to stage C192 ICs
(note: these have not been placed in the centralized location.)
  • Loading branch information
WalterKolczynski-NOAA committed Feb 28, 2024
1 parent d3a4927 commit b7af315
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
5 changes: 0 additions & 5 deletions ci/cases/pr/C48_S2SWA_gefs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,3 @@ arguments:
idate: 2021032312
edate: 2021032312
yaml: {{ HOMEgfs }}/ci/cases/yamls/gefs_ci_defaults.yaml

skip_ci_on_hosts:
- hera
- orion
- hercules
2 changes: 1 addition & 1 deletion parm/config/gfs/config.stage_ic
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ echo "BEGIN: config.stage_ic"
source "${EXPDIR}/config.resources" stage_ic

case "${CASE}" in
"C48" | "C96")
"C48" | "C96" | "C192")
export CPL_ATMIC="workflow_${CASE}_refactored"
export CPL_ICEIC="workflow_${CASE}_refactored"
export CPL_OCNIC="workflow_${CASE}_refactored"
Expand Down
4 changes: 2 additions & 2 deletions workflow/rocoto/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,12 @@ def _get_forecast_hours(cdump, config, component='atmos') -> List[str]:
local_config['FHOUT'] = config['FHOUT_OCNICE']

fhmin = local_config['FHMIN']
fhmax = local_config['FHMAX']
fhout = local_config['FHOUT']

# Get a list of all forecast hours
fhrs = []
if cdump in ['gdas']:
fhmax = local_config['FHMAX']
fhout = local_config['FHOUT']
fhrs = list(range(fhmin, fhmax + fhout, fhout))
elif cdump in ['gfs', 'gefs']:
fhmax = local_config['FHMAX_GFS']
Expand Down

0 comments on commit b7af315

Please sign in to comment.