Implement unwrap for lower-case type strings #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid failing with a "No data type (B, BS, N, NS, S, SS)" error when type strings are not upper case.
kayomarz
reviewed
Mar 27, 2017
There was a problem hiding this comment.
@arichiardi Thanks for the pull-request.
If DynamoDB SDK doesn't support lower-case type strings, I'm not sure if its a good idea for this library to convert case. This library is just a light wrapper.
|
Well, I have had DynamoDB extract data in lowercase while using Data Pipeline that is why I needed it. In any case up to you 😀 |
|
Ok. I understand.
I will merge your pull request, maybe with a global flag to allow lowercase
data types. Maybe something like:
var ddt = require('dynamodb-data-types');
ddt.allowLowercaseDataType();
Let me know if you have any other suggestion. Thanks!
On 27-Mar-2017 10:42 am, "Andrea Richiardi" <notifications@github.com> wrote:
Well, I have had DynamoDB extract data in lowercase while using Data
Pipeline that is why I needed it.
In any case up to you 😀
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIkCXoXr-8iMM3exO76FgKqJfjlDtYDks5rp8rLgaJpZM4MnKPQ>
.
|
|
In my experience of importing/exporting text files into/from DynamoDB using Data Pipeline, only the first letter of the data type is set to lower case. Additionally, it places a char(3) rather than a colon between root level field names & their data and then a char(2) between fields. YMMV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid failing with a "No data type (B, BS, N, NS, S, SS)" error when
type strings are not upper case.