Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #7 #8

Merged
merged 3 commits into from
Apr 8, 2016
Merged

Fix Issue #7 #8

merged 3 commits into from
Apr 8, 2016

Conversation

BryanCrotaz
Copy link
Contributor

Dynamo API doesn't allow zero length strings. This library discovers that a parameter is a string so seems the correct place to handle storing empty strings as nulls.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 95.977% when pulling 7a8517f on silver-curve:Fix_Empty_Strings into e8a80eb on kayomarz:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 96.552% when pulling 983482b on silver-curve:Fix_Empty_Strings into e8a80eb on kayomarz:master.

@kayomarz kayomarz merged commit 43993f1 into kayomarz:master Apr 8, 2016
kayomarz added a commit that referenced this pull request Jul 10, 2016
@kayomarz
Revert "Fix Issue #7 (#8)"
ae3a722 
This reverts commit 43993f1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BryanCrotaz @coveralls @kayomarz