Rewrite XS code to fix bug #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A review of the XS code in this module raised some questions, so we
rewrote it for clarity and fixed a bug.
- Re-work to use memchr to find ; and DRY up the case where there's no ;.
- Add some missing bounds checking on the main parsing, reworking to make
the checks more obvious.
- Fixes an issue where string starting with ';' causes a memory access
before the start of the passed string.
- Add length checks for '%##' decoding
- Fixes potential accesses past the end of the key/value
- Fix issue with quoted value handling
- A value of a single quote would cause a negative value to be passed
to svGROW().
kazeburo
added a commit
that referenced
this pull request
Mar 31, 2022
Changelog diff is:
diff --git a/Changes b/Changes
index 9986710..d414be5 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,10 @@ Revision history for Perl extension Cookie-Baker-XS
{{$NEXT}}
+0.12 2022-03-31T04:24:47Z
+
+ - Rewrite XS code to fix bug #4. Thank youk goess.
+
0.11 2019-06-07T06:30:07Z
- just bump up version. PP requires newer version number
|
Great job! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A review of the XS code in this module raised some questions, so we
rewrote it for clarity and fixed a bug.
Re-work to use memchr to find ; and DRY up the case where there's no ;.
Add some missing bounds checking on the main parsing, reworking to make
the checks more obvious.
before the start of the passed string.
Add length checks for '%##' decoding
Fix issue with quoted value handling
to svGROW().
Some performance analysis for a typical cookie: