Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBIx::Sunny's additional methods accepts bind values, even if the number of them doesn't match with the number of placeholders.
For example,
select_row
accepts the following usages:They will issue the following query. (Output by using DBIx::QueryLog)
In the former case, placeholder is replaced with
NULL
. And in the latter, extra value2
is ignored.I think those mismatch would not be what the programmer would intend. It would be safe to warn them.
This PR checks the number of bind values and warn if it doesn't match with the number of placeholders.