Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined name make_mala_sampler imported from flowMC.sampler.MALA in test/test_quickstart.py #75

Closed
matt-graham opened this issue Jan 4, 2023 · 0 comments · Fixed by #87
Closed

Undefined name make_mala_sampler imported from flowMC.sampler.MALA in test/test_quickstart.py #75

matt-graham opened this issue Jan 4, 2023 · 0 comments · Fixed by #87
Assignees
@kazewong

Comments

@matt-graham
Copy link

Raising issue as part of JOSS review openjournals/joss-reviews#5021

The import statement in

flowMC/test/test_quickstart.py

Line 4 in 6585fc2

from flowMC.sampler.MALA import make_mala_sampler

fails as make_mala_sampler is not defined in src/flowMC/sampler/MALA.py.
@kazewong kazewong self-assigned this Jan 5, 2023
@kazewong kazewong linked a pull request Jan 17, 2023 that will close this issue
Update test_quickstart.py #87
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazewong kazewong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update test_quickstart.py kazewong/flowMC
2 participants
@matt-graham @kazewong