Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Default/from_bytes/is_zero and check the last byte in Id::from_str #10

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Add Default/from_bytes/is_zero and check the last byte in Id::from_str #10

merged 3 commits into from
Apr 23, 2024

Conversation

zensh
Copy link
Contributor

@zensh zensh commented Jun 13, 2023

No description provided.

@zensh
Implemented std::default::Default
2db1b5a 
Signed-off-by: 0xZensh <txr1883@gmail.com>
@zensh
check the last byte in Id::from_str, kazk#9
2cfbb0f 
Signed-off-by: 0xZensh <txr1883@gmail.com>
@zensh
Add from_bytes function and is_zero method.
8e96fc3
@kazk kazk changed the title Check the last byte in Id::from_str Add Default/from_bytes/is_zero and check the last byte in Id::from_str Apr 23, 2024
kazk
kazk approved these changes Apr 23, 2024
View reviewed changes
Copy link
Owner

@kazk kazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kazk kazk merged commit 8f27dc2 into kazk:main Apr 23, 2024
kazk added a commit that referenced this pull request Apr 23, 2024
@kazk
v1.1.0
cb6028b 
- Fix #9 by checking the last byte in `Id::from_str` (#10)
- Implement `std::default::Default` (#10)
- Add `from_bytes` function and `is_zero` method (#10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazk kazk kazk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zensh @kazk