Avoid set-coding-priority for Emacs 28 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazu-yamamoto
requested changes
Dec 1, 2020
mew-env.el
Outdated
| @@ -99,7 +99,8 @@ requires PTY.") | |||
|
|
|||
| (with-no-warnings | |||
| (defun mew-set-coding-priority (pri) | |||
| (set-coding-priority pri))) | |||
| (apply 'set-coding-system-priority | |||
| (mapcar #'(lambda (x) (symbol-value x)) pri)))) | |||
There was a problem hiding this comment.
I guess that #' is not necessary because lambda is a macro in Elisp.
There was a problem hiding this comment.
Let's remove
#'if possible.
Done. (rebased and force pushed)
tats
force-pushed
the
bug/coding-priority
branch
from
2f41c7d
to
83b7302
Compare
|
Merged. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a recent Emacs 28.0.50, C-c C-l (mew-summary-convert-local-cs) fails
with the error: (void-function set-coding-priority), because the
set-coding-priority function obsolete since Emacs 23.1 have been removed.
cf. http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=874ba85363e90a54f976af542e9b3f4c662e317e