Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mew-smtp-ssl-port when mew-smtp-ssl for passtag and log #151

Closed
wants to merge 1 commit into from

Conversation

tats
Copy link
Collaborator

@tats tats commented Jan 29, 2021

Currently, mew-smtp-passtag() and mew-smtp-log() use mew-smtp-port
even if mew-smtp-ssl is t. Instead, mew-smtp-ssl-port should be used.

@tats
Copy link
Collaborator Author

tats commented Jan 30, 2021

Though the mew-smtp-passtag() issue is minor, the mew-smtp-log() issue
is slightly important.

When mew-smtp-ssl is t, mew-smtp-port is 25, and mew-smtp-ssl-port
is 465, ...:25 SSL/TLS... is logged to ~/Mail/Smtplog. It should
be ...:465 SSL/TLS....

@kazu-yamamoto kazu-yamamoto self-requested a review January 31, 2021 07:38
Copy link
Owner

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

kazu-yamamoto added a commit that referenced this pull request Jan 31, 2021
@kazu-yamamoto
Copy link
Owner

Merged. Thank you for your contribution!

@tats tats closed this Jan 31, 2021
@tats tats deleted the bug/smtplog branch February 6, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants