Properly close streams #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incidentally, without this PR, a call to |
edsko
added a commit
to well-typed/grapesy
that referenced
this pull request
Jan 6, 2024
We still depend on a fix to `http2`; without it, depending on whether or not the GC is able to detect an STM deadlock, the tests can hang. See kazu-yamamoto/http2#104 for details.
edsko
added a commit
to well-typed/grapesy
that referenced
this pull request
Jan 11, 2024
We still depend on a fix to `http2`; without it, depending on whether or not the GC is able to detect an STM deadlock, the tests can hang. See kazu-yamamoto/http2#104 for details.
edsko
added a commit
to well-typed/grapesy
that referenced
this pull request
Jan 11, 2024
We still depend on a fix to `http2`; without it, depending on whether or not the GC is able to detect an STM deadlock, the tests can hang. See kazu-yamamoto/http2#104 for details.
|
@kazu-yamamoto FWIW the aforementioned @edsko's blogpost has been published at https://well-typed.com/blog/2024/01/when-blocked-indefinitely-is-not-indefinite/ |
|
Yes. I tweeted about the blog post already. |
|
Rebased and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids another "blocked indefinitely" in client code, following on from #97. I suspect that there are probably others, still.
@kazu-yamamoto I'm not entirely sure which exception to use when the stream is closed; if
ConnectionIsClosedis not the right one, let me know. Also, I think the firstOpen/Opencase probably never arises in practice, but this way the code doesn't make any assumptions; but in principle I think we can just leave out this case (but I'm not 100% sure).Incidentally, I am writing a blog post about deadlock detection in STM, which also illustrates why fixes like this are important; I'll post a link once I have a preview in case you're curious.