Use time-manager >= 0.1.0 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FinleyMcIlwaine
force-pushed
the
finley/update-time-manager
branch
from
7f815af
to
e4565b8
Compare
The new time-manager API removes `Handle`s immediately upon `cancel`, rather than relying on a timeout to occur. This effects http2 since servers processing many streams with a very long timeout will no longer accumulate `Handle`s, as the `Handle`s will be removed immediately when the stream is closed. Bumped version to 5.2.1.
FinleyMcIlwaine
force-pushed
the
finley/update-time-manager
branch
from
e4565b8
to
74a7899
Compare
|
@kazu-yamamoto The good news is that initial testing suggests that after this PR, a |
|
All relating packages are released. |
|
Thanks @kazu-yamamoto ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new time-manager API removes
Handles immediately uponcancel, rather than relying on a timeout to occur. This effects http2 since servers processing many streams with a very long timeout will no longer accumulateHandles, as theHandles will be removed immediately when the stream is closed.This PR bumps the time-manager dependency to include these changes and bumps the http2 version to 5.2.1.