Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using concurrent_ for servers #67

Merged
merged 1 commit into from
Apr 6, 2023
Merged

using concurrent_ for servers #67

merged 1 commit into from
Apr 6, 2023

Conversation

kazu-yamamoto
Copy link
Owner

No description provided.

@kazu-yamamoto kazu-yamamoto changed the title don't send goway after rst_stream using concurrent_ for servers Apr 6, 2023
@kazu-yamamoto
Copy link
Owner Author

Servers using race_.

When frameReceiver in a server generates RST_Stream, it dies.
There is no grantee that frameSender sends RST_Stream.
Then the connection is closed by the server side.
The client receives FIN instead of RST_Stream.

This makes the "missing" test case fragile.

Let's use concurrently_ like clients!

@kazu-yamamoto kazu-yamamoto merged commit e2b0f9c into master Apr 6, 2023
@kazu-yamamoto kazu-yamamoto deleted the poc-win branch April 6, 2023 10:56
@kazu-yamamoto kazu-yamamoto mentioned this pull request Apr 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kazu-yamamoto