Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce forkManaged #74

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Introduce forkManaged #74

merged 2 commits into from
Apr 24, 2023

Conversation

edsko
Copy link
Contributor

@edsko edsko commented Apr 20, 2023

Fixes #73.

@edsko edsko mentioned this pull request Apr 20, 2023
Closed
@edsko
Copy link
Contributor Author

edsko commented Apr 20, 2023

@kazu-yamamoto I was confused for a while by the use of deleteMyId in worker, since I couldn't find the corresponding addMyId. I think I now understand what is going on, and I tried to add a few comments to explain it. If they are wrong, let me know! :)

@edsko
Copy link
Contributor Author

edsko commented Apr 20, 2023

I think the CI failure is actually #72 . Will fix.

@edsko
Fix compilation failure in 9.0
0549d1f 
This was a remnant of kazu-yamamoto#72 (CI did not run, I guess).
@kazu-yamamoto kazu-yamamoto self-requested a review April 24, 2023 01:46
kazu-yamamoto
kazu-yamamoto approved these changes Apr 24, 2023
View reviewed changes
Copy link
Owner

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent to me!

@kazu-yamamoto kazu-yamamoto merged commit 3aa161e into kazu-yamamoto:master Apr 24, 2023
15 checks passed
@kazu-yamamoto
Copy link
Owner

Thank you for your contribution!

@edsko edsko deleted the edsko/fix-sendRequest branch April 25, 2023 08:55
@edsko edsko mentioned this pull request May 9, 2023
Closed
kazu-yamamoto added a commit that referenced this pull request Jun 14, 2023
@kazu-yamamoto
Merge pull request #74 from edsko/edsko/fix-sendRequest
1bed6ca 
Introduce `forkManaged`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in sendRequest?
2 participants
@edsko @kazu-yamamoto