Don't use generic ThreadKilled
#79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using a specific exception debugging of client code becomes easier: when we see a thread killed using `ThreadKilled`, it could come from anywhere, but when we see a thread killed using `KilledByHttp2ThreadPoolManager`, it can only come from one place.
|
CI timeout on Windows is I think not related to this PR? |
|
@edsko Don't worry about Windows stuff. |
|
Rebased and merged. |
|
@kazu-yamamoto I am working on #77 again, when I noticed http2/Network/HTTP2/Server/Worker.hs Line 171 in 366560b Perhaps I should have changed that line as part of this PR? |
|
Yeah. Would you send another PR to fix this? |
edsko
added a commit
to edsko/http2
that referenced
this pull request
Jul 25, 2023
Yup, #81. |
akshaymankar
pushed a commit
to wireapp/http2
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using a specific exception debugging of client code becomes easier: when we see a thread killed using
ThreadKilled, it could come from anywhere, but when we see a thread killed usingKilledByHttp2ThreadPoolManager, it can only come from one place.